ExSlop.Check.Refactor.RedundantBooleanIf (ExSlop v0.4.0)

Copy Markdown View Source

Basics

This check is disabled by default.

Learn how to enable it via .credo.exs.

This check has a base priority of normal and works with any version of Elixir.

Explanation

if condition, do: true, else: false is redundant — the condition already evaluates to a boolean (or can be made one with !!).

# bad — wrapping a boolean condition in if/true/false
is_active = if status == :active, do: true, else: false
if !is_nil(x) and !is_nil(y), do: true, else: false

# good — use the expression directly
is_active = status == :active
!is_nil(x) and !is_nil(y)

Check-Specific Parameters

There are no specific parameters for this check.

General Parameters

Like with all checks, general params can be applied.

Parameters can be configured via the .credo.exs config file.