ExSlop.Check.Refactor.IdentityPassthrough (ExSlop v0.3.0)

Basics

This check has a base priority of normal and works with any version of Elixir.

Explanation

A case or with that matches patterns only to return the same thing is a no-op — just return the value directly.

# bad — identity passthrough
case result do
  {:ok, value} -> {:ok, value}
  {:error, reason} -> {:error, reason}
end

# good
result

# bad — with + else that does nothing
with {:ok, result} <- do_something() do
  {:ok, result}
else
  {:error, reason} -> {:error, reason}
end

# good
do_something()

Check-Specific Parameters

There are no specific parameters for this check.

General Parameters

Like with all checks, general params can be applied.

Parameters can be configured via the .credo.exs config file.